[CI:DOCS] Add doc to build podman on windows without MSYS #21910
Conversation
| If the command returns `Restricted` you should change the ExecutionPolicy to `RemoteSigned`: | ||
|
|
||
| ``` | ||
| Set-ExecutionPolicy -ExecutionPolicy RemoteSigned -Scope CurrentUser |
There was a problem hiding this comment.
you prob need to note what the ramifications of this are.
There was a problem hiding this comment.
You mean that the comment "This policy allows the execution of local PowerShell scripts" is not enough?
There was a problem hiding this comment.
I think we you change something like this, it is prob a good idea to outright let people they are theoretically changing the security level of their machine; given that the default was to be tighter.
There was a problem hiding this comment.
A note saying something to that effect would be good. When ever a a change is made system wide, especially if it changes security settings, it should be highlighted.
|
|
||
| # Downlaod gvproxy.exe and win-sshproxy.exe | ||
| # that are needed to execute the podman client | ||
| .\winmake.ps1 win-gvproxy |
There was a problem hiding this comment.
do you think we should have an install target in the winmake file that does this and podman and puts it into the filesystem
There was a problem hiding this comment.
I don't know. Putting it in the filesystem may be problematic. What if you already have a stable podman installed but just want to test main branch?
And I was thinking that podman.exe should look for the helpers in it's directory. This was also how I interpretated this comment. This is not working currently and if it is appropriate I can create an issue and work on it.
Another issue is that the version of gvproxy and sshproxy is currently hardcoded.
There was a problem hiding this comment.
if you have a stable podman, fwiw, there will be no impact. But, what i meant is if you did something like ./winmake install then it would.
|
|
||
| Podman requires brew -- a collection of Unix like build tools and libraries adapted for Windows. More details and | ||
| installation instructions are available from their [home page](https://www.msys2.org/). There are also premade GitHub | ||
| actions for this tool that are available. | ||
|
|
||
| ## Install build dependencies | ||
| ### Install build dependencies |
There was a problem hiding this comment.
Just this paragraph or the full "Building the Podman client and installer with MSYS2" section?
There was a problem hiding this comment.
imho, msys2 is NOT required to build on windows; and adding it just confuses things. Probably others should also weigh in on this notion
There was a problem hiding this comment.
Agreed. I was careful to keep both options as there was no final decision yet. But I can remove the MSYS2 instructions if that's the consensus.
There was a problem hiding this comment.
I hacked up a lot of the English. We don't allow pronouns (you, your, me, I, etc) in our manpages, at least we highly discourage them. I realize this is not a man page per se, but I think it reads better without the pronouns. Use the changes if you wish.
Things to note, "Podman" and not "podman" unless in a command or a command example. Watch acronyms, especially in the first instance, and in general, stay away from abbreviations. It's better to do "administrator" instead of "admin" for instance.
I did just a English/grammar check, and did not test to make sure it was technically correct.
Regardless of my red marks, a really nice addition, thanks @l0rd !
|
Thank you @TomSweeneyRedHat for this review. I have accepted all your suggestions. |
l0rd
changed the title
build_windows.md
Outdated
|
|
||
| Podman on Windows can run on the [Windows Subsystem for Linux (WSL)](https://learn.microsoft.com/en-us/windows/wsl/) or | ||
| on [Hyper-V](https://learn.microsoft.com/en-us/virtualization/hyper-v-on-windows/quick-start/enable-hyper-v) . | ||
| To us Hyper-V use the following command: |
There was a problem hiding this comment.
Suggest: To use Hyper-V, enter the foolowing command
build_windows.md
Outdated
|
|
||
| ### Enable Hyper-V (optional) | ||
|
|
||
| Podman on Windows can run on the [Windows Subsystem for Linux (WSL)](https://learn.microsoft.com/en-us/windows/wsl/) or |
There was a problem hiding this comment.
Maybe mention that HyperV is not included by all Windows editions?
|
Lint complains about trailing whitespace |
l0rd
force-pushed
the
windows-build-doc
branch
2 times, most recently
from
a393b14
to
dd1415b
Compare
Updated build_windows.md with a new section that document how to build and run the windows podman client without the need to install MSYS. [NO NEW TESTS NEEDED] Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: l0rd, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
stale-locking-app
bot
added
the
locked - please file new issue/PR
Updated build_windows.md with a new section that documents how to build and run the windows podman client without requiring MSYS.
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?