Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup image prune help #2200

Closed
wants to merge 1 commit into from
Closed

Fixup image prune help #2200

wants to merge 1 commit into from

Conversation

baude
Copy link
Member

@baude baude commented Jan 21, 2019

Correct the help text for the image prune command to state that it
removes all unused images.

Issue: #2192

Signed-off-by: baude bbaude@redhat.com

Correct the help text for the image prune command to state that it
removes all unused images.

Issue: containers#2192

Signed-off-by: baude <bbaude@redhat.com>
@baude
Copy link
Member Author

baude commented Jan 21, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2019
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get the discussion in #2192 resolved, I don't think this is correct, but could be proven wrong. If this is indeed the same behavior as Docker, then LGTM. Then again we might want to change this now as this reflects the reality of Podman ATM.

@baude baude closed this Jan 22, 2019
@baude baude deleted the prunehelp branch December 22, 2019 19:03
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants