podman image prune -- implement all flag #2205
Conversation
baude
requested review from
jwhonce and
TomSweeneyRedHat
and removed request for
mheon
baude
force-pushed
the
prunelikedocker
branch
from
d4e1224
to
9231355
Compare
|
/approve |
openshift-ci-robot
added
the
approved
| @@ -57,6 +56,7 @@ var _ = Describe("Podman rm", func() { | |||
| }) | |||
|
|
|||
| It("podman image prune none images", func() { | |||
| SkipIfRemote() | |||
There was a problem hiding this comment.
Is this test making a "" image? I think so, but am not 100% sure. Can we add a check to validate that there is a non-dangling image still when it's complete?
There was a problem hiding this comment.
ugh, s/b "making a <none> image"
There was a problem hiding this comment.
Yes this builds something that leaves behind dangling images (none ones). Added an expect to make sure named, unused images are not deleted.
baude
force-pushed
the
prunelikedocker
branch
from
9231355
to
bc468b8
Compare
we now, by default, only prune dangling images. if --all is passed, we prune dangling images AND images that do not have an associated containers. also went ahead and enabled the podman-remote image prune side of things. Fixes: containers#2192 Signed-off-by: baude <bbaude@redhat.com>
baude
force-pushed
the
prunelikedocker
branch
from
bc468b8
to
656033c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
has bash completions now. |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
we now, by default, only prune dangling images. if --all is passed, we
prune dangling images AND images that do not have an associated containers.
also went ahead and enabled the podman-remote image prune side of things.
Fixes: #2192
Signed-off-by: baude bbaude@redhat.com