Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: remove compose v1 tests #22421

Merged
merged 2 commits into from
Apr 18, 2024
Merged

CI: remove compose v1 tests #22421

merged 2 commits into from
Apr 18, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Apr 18, 2024

compose v1 has been deprecated for some time now, since July 2023 it no
longer receives any updates[1]. As such testing it on every PR is
pointless, it also does not provide any more coverage then compose v2.
At least I never saw only compose v1 test fails (except for flakes) so
it doesn't help us to catch regressions.
We tried to remove it before but decided against it at that time[2].

[1] https://docs.docker.com/compose/migrate/
[2] #18688

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 18, 2024
@Luap99
Copy link
Member Author

Luap99 commented Apr 18, 2024

If anyone thinks it is valuable to have these please speak up.

@Luap99
Copy link
Member Author

Luap99 commented Apr 18, 2024

@cevich @edsantiago PTAL

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

edsantiago
edsantiago approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misleading typo in 2nd commit message, should be "now that we only test compose v2". I have a medium to medium-high preference for fixing this, but will not block.

Otherwise LGTM with one cleanup suggestion inline. Thanks for noticing and fixing this.

.cirrus.yml Outdated Show resolved Hide resolved
@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 4d3b096a100ff76f2ea0c1e3e31c412e148b87bf. @martinpitt, @jelly, @mvollmer please check.

@Luap99
CI: remove compose v1 tests
2c61ee9 
compose v1 has been deprecated for some time now, since July 2023 it no
longer receives any updates[1]. As such testing it on every PR is
pointless, it also does not provide any more coverage then compose v2.
At least I never saw only compose v1 test fails (except for flakes) so
it doesn't help us to catch regressions.
We tried to remove it before but decided against it at that time[2].

[1] https://docs.docker.com/compose/migrate/
[2] containers#18688

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99
test/compose: remove compose v1 code
b1736c4 
Now that we only test compose v2 remove the special cases from the test
code to simply the tests.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit b1736c4. @martinpitt, @jelly, @mvollmer please check.

@edsantiago
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@mheon
Copy link
Member

mheon commented Apr 18, 2024

LGTM

cevich
cevich reviewed Apr 18, 2024
View reviewed changes
.cirrus.yml Show resolved Hide resolved
cevich
cevich approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6eaa1d5 into containers:main Apr 18, 2024
89 of 92 checks passed
@Luap99 Luap99 deleted the compose-test branch April 18, 2024 14:59
@lunik1 lunik1 mentioned this pull request Apr 23, 2024
Open
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jul 18, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cevich cevich cevich approved these changes

@edsantiago edsantiago edsantiago approved these changes

Assignees

@edsantiago edsantiago

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Luap99 @edsantiago @mheon @cevich