Additional potential race condition on os.Readdir

[rhatdan]

Does this PR introduce a user-facing change?

None

[packit-as-a-service]

We were not able to find or create Copr project packit/containers-podman-23587 specified in the config with the following error:

Packit received HTTP 500 Internal Server Error from Copr Service. Check the Copr status page: https://copr.fedorainfracloud.org/status/stats/, or ask for help in Fedora Build System matrix channel https://matrix.to/#/#buildsys:fedoraproject.org.

---

Unless the HTTP status code above is >= 500, please check your configuration for:

1. typos in owner and project name (groups need to be prefixed with @)
2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
3. whether the project itself exists (Packit creates projects only in its own namespace)
4. whether Packit is allowed to build in your Copr project
5. whether your Copr project/group is not private

[rhatdan]

@Luap99 @edsantiago Searched for all os.Readdir in code base and only found this one other instance, where we have a potential race condition.

[edsantiago]

Good proactive thinking, thanks. I can't comment on the safety of this patch, but FWIW the string "Deallocating lock" does not appear in my multi-year archive of flake logs.

[Luap99]

LGTM

[Luap99]

Good proactive thinking, thanks. I can't comment on the safety of this patch, but FWIW the string "Deallocating lock" does not appear in my multi-year archive of flake logs.

This touches file locks abstraction that we are not using anywhere in our testing because we default to the shm based locks. So that code was never called.
Second this code is only used for podman system renumber which is not safe at all to use in parallel with other commands and calling to of them at the same to to trigger this would possibly break many other things first.

[Luap99]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment