Fix podman command --change CMD #2952
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
Closes: #2951 |
|
LGTM |
test/e2e/commit_test.go
Outdated
| @@ -117,6 +117,31 @@ var _ = Describe("Podman commit", func() { | |||
| Expect(foundBlue).To(Equal(true)) | |||
| }) | |||
|
|
|||
| FIt("podman commit container with change CMD flag", func() { | |||
There was a problem hiding this comment.
looks like the CI is complaining this test is taking too long?
There was a problem hiding this comment.
Extra F on the test here? "It" instead of "FIt"?
| @@ -125,23 +125,48 @@ func (c *Container) Commit(ctx context.Context, destImage string, options Contai | |||
| // Workdir | |||
| importBuilder.SetWorkDir(c.Spec().Process.Cwd) | |||
|
|
|||
| genCmd := func(cmd string) []string { | |||
There was a problem hiding this comment.
At some point we need to do regexes for all of this. Reviewing these complex parsing functions makes my head hurt sometimes.
|
LGTM once tests go green |
Currently in Docker if you commit with --change 'CMD a b c' The command that gets added is [/bin/sh -c "a b c"] If you commit --change 'CMD ["a","b","c"]' You get [a b c] This patch set makes podman match this behaviour. Similar change required for Entrypoint. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
Can someone give this a /lgtm |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Currently in Docker if you commit with --change 'CMD a b c'
The command that gets added is
[/bin/sh -c "a b c"]
If you commit --change 'CMD ["a","b","c"]'
You get
[a b c]
This patch set makes podman match this behaviour.
Similar change required for Entrypoint.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com