Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not remove volumes when --rm removes a container #3072

Merged
merged 1 commit into from
May 8, 2019
Merged

Do not remove volumes when --rm removes a container #3072

merged 1 commit into from
May 8, 2019
+7 −4

Conversation

mheon
Copy link
Member

@mheon mheon commented May 6, 2019

This duplicates Docker behavior for the --rm flag.

Fixes #3071

@mheon
Do not remove volumes when --rm removes a container
5c6ff90 
This duplicates Docker behavior for the `--rm` flag.

Fixes containers#3071

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S labels May 6, 2019
@mheon
Copy link
Member Author

mheon commented May 6, 2019

(Also includes a small tweak to --rm manpage)

@mheon mheon mentioned this pull request May 6, 2019
Closed
@jwhonce
Copy link
Member

jwhonce commented May 6, 2019

LGTM
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2019
@jwhonce
Copy link
Member

jwhonce commented May 8, 2019

/lgtm
See if an additional label will kick the bot into action

@mheon
Copy link
Member Author

mheon commented May 8, 2019

Github apparently thinks the label was added "4 hours from now" which could be it

@jwhonce
Copy link
Member

jwhonce commented May 8, 2019

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 8, 2019
@jwhonce
Copy link
Member

jwhonce commented May 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2019
@containers containers deleted a comment from giuseppe May 8, 2019
@containers containers deleted a comment from giuseppe May 8, 2019
@mheon
Copy link
Member Author

mheon commented May 8, 2019

I'm going to manually toggle the label

@mheon mheon added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels May 8, 2019
@jwhonce
Copy link
Member

jwhonce commented May 8, 2019

I also deleted the "future" commands

@mheon
Copy link
Member Author

mheon commented May 8, 2019

We don't seem to be getting anywhere here.

@stevekuznetsov Can you take a peek at this? We have appropriate labels set for merge, but Tide isn't respecting it.

@openshift-merge-robot openshift-merge-robot merged commit 627dbd4 into containers:master May 8, 2019
@cevich cevich mentioned this pull request May 13, 2019
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baude baude Awaiting requested review from baude

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@jwhonce jwhonce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For 'podman run --rm', do not remove named volumes (align with Docker behaviour)
5 participants
@mheon @jwhonce @openshift-ci-robot @giuseppe @openshift-merge-robot