Minor fix splitting env vars in podman-commit

[weirdwiz]

string.Split() splits into slice of size greater than 2
which may result in loss of environment variables

fixes #3132

[rh-atomic-bot]

Can one of the admins verify this patch?
I understand the following commands:

• bot, add author to whitelist
• bot, test pull request
• bot, test pull request once

[mheon]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, weirdwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

/ok-to-test

[mheon]

Code LGTM

[rhatdan]

@weirdwiz Could you add a quick test to verify that the reported issue is fixed by this and will not happen again.

[rhatdan]

Wrong issue.

[TomSweeneyRedHat]

Dang @weirdwiz , your fingers are faster than mine. I'd not realized you'd been assigned this one and was just about to spin up a PR. I've tested and this fixes the issue. A new test wouldn't hurt any.
LGTM other than the test.

[weirdwiz]

@rhatdan I have added the test

I cannot figure out why you are getting permission denied on your system, I have only changed a line regarding splitting the string in the commit command, I don't see how this could affect the run command.

[TomSweeneyRedHat]

@weirdwiz ignore @rhatdan's perm comment, he'd too many windows up at once and put a comment here in this PR that was meant for another project entirely. Thanks for the added test.

[TomSweeneyRedHat]

LGTM assuming happy tests.

[weirdwiz]

All tests passing now :D

[mheon]

/lgtm