-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for testing with the latest Ubuntu release #3754
Add support for testing with the latest Ubuntu release #3754
Conversation
b704751
to
7e96ca4
Compare
These were produced as an intended byproduct of: containers/podman#3754 Where 'systemd_banish.sh' was run during base-image production. This is a short-term fix, as there is much setup duplication here which can (hopefully) be avoided with: containers#408 Signed-off-by: Chris Evich <cevich@redhat.com>
These were produced as an intended byproduct of: containers/podman#3754 Where 'systemd_banish.sh' was run during base-image production. Therefor, during run-time there should no longer be interference of testing by background/periodic processes. Signed-off-by: Chris Evich <cevich@redhat.com>
Note: This PR is blocked until we get |
☔ The latest upstream changes (presumably #3594) made this pull request unmergeable. Please resolve the merge conflicts. |
These were produced as an intended byproduct of: containers/podman#3754 Where 'systemd_banish.sh' was run during base-image production. This is a short-term fix, as there is much setup duplication here which can (hopefully) be avoided with: containers#408 Signed-off-by: Chris Evich <cevich@redhat.com>
☔ The latest upstream changes (presumably #3789) made this pull request unmergeable. Please resolve the merge conflicts. |
@lsm5 just FYI - this is the PR that brings Ubuntu 19 into the mix. |
(waiting to rebase until Lokesh's new/fixed packages are ready for Ubuntu 19) |
try now |
Thanks @lsm5 needed to rebase this PR anyway, running now... |
6fe2ab9
to
ef5e788
Compare
☔ The latest upstream changes (presumably #3994) made this pull request unmergeable. Please resolve the merge conflicts. |
760d451
to
f245c4f
Compare
Okay, I think this is ready for review now. There are a lot of changes here required for my F31-support PR and a handful of minor/cosmetic fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A couple of questions though.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add the latest Ubuntu version into the testing matrix and image-build workflow. This is also needed to support other containers projects which share use of VM images from this one. Update package lists to include needs for contianers/storage use of images. Signed-off-by: Chris Evich <cevich@redhat.com>
Also, minor update to prevent harmless 'Fatal: not a git repo' error. Signed-off-by: Chris Evich <cevich@redhat.com>
The images build correctly but neither integration or remote client tests pass. Temporarily disable Ubuntu 19 testing until both are ready to be supported. Signed-off-by: Chris Evich <cevich@redhat.com>
f245c4f
to
a6534a7
Compare
(force-pushed, rebased, and added a comment in case others have same question that Dan did) |
/lgtm |
Add the latest Ubuntu version into the image-build matrix and image-build workflow. This is needed to support other containers projects which share use of VM images from this one. Testing on Ubuntu 19 is "commented out" temporarily, to be enabled when tests are ready
Depends on #3607 #3822 #3934 #3985 #4054 #4054