Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for testing with the latest Ubuntu release #3754

Merged
merged 3 commits into from
Sep 21, 2019

Conversation

cevich
Copy link
Member

@cevich cevich commented Aug 7, 2019

Add the latest Ubuntu version into the image-build matrix and image-build workflow. This is needed to support other containers projects which share use of VM images from this one. Testing on Ubuntu 19 is "commented out" temporarily, to be enabled when tests are ready

Depends on #3607 #3822 #3934 #3985 #4054 #4054

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2019
@cevich cevich force-pushed the latest_ubuntu branch 5 times, most recently from b704751 to 7e96ca4 Compare August 9, 2019 14:53
cevich added a commit to cevich/storage that referenced this pull request Aug 9, 2019
These were produced as an intended byproduct of:
containers/podman#3754

Where 'systemd_banish.sh' was run during base-image production.

This is a short-term fix, as there is much setup duplication
here which can (hopefully) be avoided with:
containers#408

Signed-off-by: Chris Evich <cevich@redhat.com>
cevich added a commit to cevich/buildah that referenced this pull request Aug 9, 2019
These were produced as an intended byproduct of:
containers/podman#3754

Where 'systemd_banish.sh' was run during base-image production.
Therefor, during run-time there should no longer be interference
of testing by background/periodic processes.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
Copy link
Member Author

cevich commented Aug 9, 2019

Note: This PR is blocked until we get criu packages for Ubuntu 19.04 (adrianr todo week of aug 12th)

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #3594) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2019
cevich added a commit to cevich/storage that referenced this pull request Aug 12, 2019
These were produced as an intended byproduct of:
containers/podman#3754

Where 'systemd_banish.sh' was run during base-image production.

This is a short-term fix, as there is much setup duplication
here which can (hopefully) be avoided with:
containers#408

Signed-off-by: Chris Evich <cevich@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2019
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #3789) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2019
@cevich
Copy link
Member Author

cevich commented Aug 12, 2019

@lsm5 just FYI - this is the PR that brings Ubuntu 19 into the mix.

@cevich
Copy link
Member Author

cevich commented Aug 12, 2019

(waiting to rebase until Lokesh's new/fixed packages are ready for Ubuntu 19)

@lsm5
Copy link
Member

lsm5 commented Aug 12, 2019

(waiting to rebase until Lokesh's new/fixed packages are ready for Ubuntu 19)

try now

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2019
@cevich
Copy link
Member Author

cevich commented Aug 13, 2019

Thanks @lsm5 needed to rebase this PR anyway, running now...

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #3994) made this pull request unmergeable. Please resolve the merge conflicts.

@cevich cevich force-pushed the latest_ubuntu branch 4 times, most recently from 760d451 to f245c4f Compare September 17, 2019 20:30
@cevich
Copy link
Member Author

cevich commented Sep 18, 2019

Okay, I think this is ready for review now. There are a lot of changes here required for my F31-support PR and a handful of minor/cosmetic fixes.

Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
A couple of questions though.

.cirrus.yml Show resolved Hide resolved
contrib/cirrus/lib.sh Show resolved Hide resolved
@mheon
Copy link
Member

mheon commented Sep 19, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2019
Add the latest Ubuntu version into the testing matrix
and image-build workflow. This is also needed to support
other containers projects which share use of VM images
from this one.

Update package lists to include needs for contianers/storage
use of images.

Signed-off-by: Chris Evich <cevich@redhat.com>
Also, minor update to prevent harmless 'Fatal: not a git repo' error.

Signed-off-by: Chris Evich <cevich@redhat.com>
The images build correctly but neither integration or remote client
tests pass.  Temporarily disable Ubuntu 19 testing until both are
ready to be supported.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
Copy link
Member Author

cevich commented Sep 20, 2019

(force-pushed, rebased, and added a comment in case others have same question that Dan did)

@rhatdan
Copy link
Member

rhatdan commented Sep 21, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2019
@openshift-merge-robot openshift-merge-robot merged commit e947d63 into containers:master Sep 21, 2019
@cevich cevich deleted the latest_ubuntu branch June 30, 2021 18:11
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants