build: pass down the cgroup manager to buildah #3944
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
giuseppe
force-pushed
the
build-cgroup-manager
branch
2 times, most recently
from
2ca3565
to
42f2acf
Compare
| } | ||
| if conf.CgroupManager == "systemd" { | ||
| runtimeFlags = append(runtimeFlags, "--systemd") | ||
| } |
There was a problem hiding this comment.
I'm not seeing this --systemd flag in the buildah bud or the podman build man pages. Should it be added?
There was a problem hiding this comment.
this option is passed down to the OCI runtime AFAICS, so Buildah doesn't need to know about it
There was a problem hiding this comment.
OK, let me reask. Would a user ever have to type --systemd ? If so, then we need to document it in a man page somewhere. If it's all internal, then no need.
There was a problem hiding this comment.
We have not had to deal with it yet, but I think adding this to buildah would be useful.
There was a problem hiding this comment.
an user could force --runtime-flag systemd for buildah but I think that is an internal detail and the current documentation covers it
|
/test images |
|
LGTM |
|
Build failures in podman-remote |
|
Changes LGTM otherwise though |
giuseppe
force-pushed
the
build-cgroup-manager
branch
from
42f2acf
to
f4affaf
Compare
I am not sure what is the proper fix for it, I've pushed a new version that at least builds now |
giuseppe
force-pushed
the
build-cgroup-manager
branch
from
f4affaf
to
afe70e7
Compare
Pass down the cgroup manager to use to buildah. Closes: containers#3938 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
build-cgroup-manager
branch
from
afe70e7
to
06f94be
Compare
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Pass down the cgroup manager to use to buildah.
Closes: #3938
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com