play kube: fix segfault #3958
play kube: fix segfault #3958
Conversation
when securityContext wasn't specified in yaml. add a test as well Signed-off-by: Peter Hunt <pehunt@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Sure, LGTM |
| if containerYAML.SecurityContext.Privileged != nil { | ||
| containerConfig.Privileged = *containerYAML.SecurityContext.Privileged | ||
| } | ||
| if containerYAML.SecurityContext != nil { |
There was a problem hiding this comment.
Could have made this a lot simpler by combining these two if commands on same line.
There was a problem hiding this comment.
for some reason, the AllowPRivilegeEscalation check was outside of the containerConfig.SecurityOpts check, so doing it this way maintained the branch structure. I didn't know enough about why that happened to choose to change it
github-actions
bot
added
the
locked - please file new issue/PR
when securityContext wasn't specified in yaml.
add a test as well
fixes: #3956
Signed-off-by: Peter Hunt pehunt@redhat.com