-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: CI/CD pipeline (tmt) - agent-flood test is failing due the change of the default Network in the qm.container #416
Comments
@dougsland need to change qm quadlet to change network=host before running |
Hi @Yarboa, after speaking with you today I was wondering here.... In the end I think this will solve partially the problem. It will get back to the green state for the CI/CD for now BUT we need to cover tests against network=private, see #417. Maybe write tests plans which we can set a variable for network type? Later we use this variable for the tests? A mock example: Test plan:
or
Later we could use in our tests: (Another mock example, something like:) test plan file:
test file using the test plan above which NETWORK is set to host:
How about this? |
Hi @dougsland , I think I may not fully get your idea, so have a few questions:
|
You are correct. The agent-flood doesn't work well when enabled in the private mode.
At this moment, the only one that needed to be skipped in host private is the agent-flood. All the rest must be equal for both.
At this moment no, but the code must be modular enough if we need to set private or host be easy as an make sense? Please let me know if you have any additional questions. |
Is the function we expect as follows (if I understand correctly):
One thing that confuses me is that in this way, the test plan is executed once will not execute all test cases, and different |
Please run all tests in both (of course, agent-flood is only possible in NETWORK==private)
No, we need to execute all tests in both scenarios (network = hosts and network = private) but as github actions + network private + agent_flood are not working well we need to skip it only in private. Make sense? |
I seem to get your meaning a little bit. |
@pengshanyu something like below, (never really tested in CI/CD the below code):
|
@dougsland Thank you so much for the details. |
That make sense but would like to see the patch to make sure we are in the same place. Also having @Yarboa eyes agreeing it would be nice. |
Hi @dougsland @Yarboa, Another question is what kind of operation mode we expect (that is, where does the original value of NETWORK come from):
|
I tried modifying “plans/e2e/ffi.fmf” and run it with
Does this make sense? |
My guess this is because we force the ENV to SKIP it: |
no, I remember |
@Yarboa do you remember something like this ? I think the test could detect the quadlet Network content, In all other network use cases other then private it should not run |
@dougsland @alexlarsson So that is not working, since there is a need to port forward from --network-private of the qm to bluechi-controller host port, IS there recommended way, to do the port forward from podman private network to controller host-port?
IIRC, Bluechi should deal with that noise for malicious activities. |
Many thanks to @alexlarsson Last update here. cat /etc/qm/bluechi/agent.conf Explanation: |
@Yarboa thanks for the info. Do you mean that we need to change the configuration of bluechi agent for ControllerHost in qm so that the agent-flood test can be run in the private network. Is my understanding correct? |
Yes, and the same goes for IP address of tests, the agent flood should connect to that host |
Hi @Yarboa , I modified the configuration mentioned above, but “bluechi-testers" still cannot start, could you help to take a look, the error is as follows:
|
Could you please try:
|
@dougsland thanks. I tried to install |
Looks like it's inside the "bluechi-tester" system. Might try to install qm: https://github.com/containers/qm/tree/main/docs/devel#installing-software-inside-qm-partition |
still got this error.
|
Okay, let's understand what's going on: First, let's reproduce the issue with a raw CentOS9:
As shown above we have reproduced exactly the issue. Now how to fix it?
So in summary, @pengshanyu do you mind to send a patch to BlueChi adding into README.md that we need to install python3-gobject ? Please NOTE this README ----> https://github.com/eclipse-bluechi/bluechi/tree/main/tests/tools/FFI cc @engelmi @mwperina @pbrilla-rh thank you |
Hi @dougsland, sure, let me sort out my thoughts and then prepare the patch. |
Adding my 5cents to the The $ dnf install python3-dasbus should also take care of installing So I am wondering: Which container image you use? @pengshanyu @dougsland
So I'd propose to replace this pip with a dnf install. This should then fix this issue at its root. |
@engelmi Thank you so much for the reply. |
The MR that installed
|
good job, thanks so much. |
Related to: #409
The text was updated successfully, but these errors were encountered: