Running single container for nodes containers #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarboa
requested review from
rhatdan,
lsm5,
dougsland and
sandrobonazzola
as code owners
Yarboa
commented
Sep 11, 2023
Yarboa
force-pushed
the
use-single-image
branch
3 times, most recently
from
831cfda
to
b64e730
Compare
Yarboa
commented
Sep 11, 2023
Resolve containers#164 nodeX images Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
Yarboa
force-pushed
the
use-single-image
branch
from
b64e730
to
fb11687
Compare
Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
|
packit blocked on fedora-copr/copr#2906 . Might wanna ignore packit builds until then if the PR is known to not interfere with rpm builds. |
|
LGTM |
Seems it is fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve images issue in #164
This PR fix the creating multi images for many nodes,
Now all node container should use node image.