Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFI test containerfile #212

Merged
merged 2 commits into from
Nov 1, 2023
Merged

FFI test containerfile #212

merged 2 commits into from
Nov 1, 2023

Conversation

Yarboa
Copy link
Collaborator

@Yarboa Yarboa commented Sep 18, 2023 •
edited
Loading

This PR is dependent with PR #210,
Do not merge

@Yarboa Yarboa marked this pull request as draft September 18, 2023 21:19
@dougsland
Copy link
Collaborator

LGTM, @rhatdan PTAL.

@dougsland
Copy link
Collaborator

/cc @dennisbrendel @priyverm

@Yarboa
Copy link
Collaborator Author

Yarboa commented Sep 19, 2023 •
edited
Loading

/cc @dennisbrendel @priyverm

It is in Draft, sine i would like to run it through tmt, tmt tests should be added

@dougsland dougsland mentioned this pull request Sep 19, 2023
Closed
Yarboa
Yarboa commented Sep 20, 2023
View reviewed changes
tests/systemd/prepare.sh Outdated Show resolved Hide resolved
@dougsland dougsland mentioned this pull request Sep 25, 2023
Closed
@Yarboa Yarboa force-pushed the FFI-container branch 2 times, most recently from 257e498 to c1f4257 Compare September 28, 2023 10:33
@dougsland
Copy link
Collaborator

@Yarboa if you are ready to review, please switch from Draft to Ready for review

@Yarboa
Copy link
Collaborator Author

Yarboa commented Oct 3, 2023 •
edited
Loading

@Yarboa if you are ready to review, please switch from Draft to Ready for review

@dougsland still working on Quay.io for qm
Once we have it, need another fix for quay url

PR is waiting for this #233 to be completed

@Yarboa Yarboa mentioned this pull request Oct 5, 2023
Closed
@rhatdan
Copy link
Member

rhatdan commented Oct 11, 2023

@Yarboa is this still active?

@Yarboa
Copy link
Collaborator Author

Yarboa commented Oct 19, 2023 •
edited
Loading

@Yarboa is this still active?

@rhatdan Yes, can continue working on it, only now.

@Yarboa Yarboa force-pushed the FFI-container branch 2 times, most recently from 0495add to be6c9fe Compare October 22, 2023 13:34
@Yarboa Yarboa marked this pull request as ready for review October 22, 2023 13:38
Yarboa
Yarboa commented Oct 22, 2023
View reviewed changes
tests/ffi/memory/test.sh Outdated Show resolved Hide resolved
@Yarboa
Copy link
Collaborator Author

Yarboa commented Oct 23, 2023 •
edited
Loading

@dougsland Please wait till tests are passing,
It seems that there is an issue with epel repos, I will try to re trigger frequently, till it will pass
Tests are failing manually , also

@Yarboa Yarboa self-assigned this Oct 23, 2023
@Yarboa Yarboa changed the title ffi test containerfile FFI test containerfile Oct 23, 2023
@Yarboa
Copy link
Collaborator Author

Yarboa commented Oct 24, 2023 •
edited
Loading

@dougsland @odra PR is blocked by this one #253
PTAL #254

Verified tests are passing with rebase #254 branch

@Yarboa
Copy link
Collaborator Author

Yarboa commented Oct 24, 2023 •
edited
Loading

@odra @dougsland @dennisbrendel @priyverm
PTAL

@Yarboa Yarboa force-pushed the FFI-container branch 3 times, most recently from 9fa6b30 to 350e79e Compare October 29, 2023 07:41
@Yarboa
Adding FFI memeory test
5b033b6 
Adding tmt FFI plan running ffi tests
Prepare script per images,
c9s, fedora, autosd (vm)
followed by test running cotainer and verify systemd activated oom killer

Adding supoport in OS based prepares
Tmt tests requires, to use tmt --context with scenario=ffi, distro=<os type> run ..

ffi-tools container image is downloaded from sig container-images

Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
dougsland
dougsland reviewed Oct 30, 2023
View reviewed changes
tests/ffi/memory/test.sh Outdated Show resolved Hide resolved
dougsland
dougsland reviewed Oct 30, 2023
View reviewed changes
tests/ffi/memory/test.sh Outdated Show resolved Hide resolved
dougsland
dougsland reviewed Oct 30, 2023
View reviewed changes
tests/ffi/memory/test.sh Outdated Show resolved Hide resolved
@dougsland
Copy link
Collaborator

In general looks good to me, few comments.

@Yarboa
Added some error catch mechanism
cf16800 
Add the following based on PR review

Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
@dougsland dougsland merged commit 985b034 into containers:main Nov 1, 2023
7 checks passed
@Yarboa Yarboa mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhatdan rhatdan rhatdan left review comments

@dougsland dougsland dougsland left review comments

@lsm5 lsm5 Awaiting requested review from lsm5 lsm5 is a code owner

@sandrobonazzola sandrobonazzola Awaiting requested review from sandrobonazzola sandrobonazzola is a code owner

@dennisbrendel dennisbrendel Awaiting requested review from dennisbrendel

@priyverm priyverm Awaiting requested review from priyverm

Assignees

@Yarboa Yarboa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yarboa @dougsland @rhatdan