Cleanup scripts #217
Merged
Cleanup scripts #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisbrendel
requested review from
rhatdan,
lsm5,
dougsland,
Yarboa,
sandrobonazzola and
priyverm
as code owners
There was some mixup of spaces and tabs, I transformed them all into tabs and aligned the indentation to be 4 spaces per level, which is what most of the file followed. Signed-off-by: Dennis Brendel <dbrendel@redhat.com>
This improves readability by a lot. Signed-off-by: Dennis Brendel <dbrendel@redhat.com>
Signed-off-by: Dennis Brendel <dbrendel@redhat.com>
Only color if the terminal has support for that, and use variables instead of using the control sequence everywhere. Signed-off-by: Dennis Brendel <dbrendel@redhat.com>
Signed-off-by: Dennis Brendel <dbrendel@redhat.com>
This fixes the mixture of tabs and spaces. Signed-off-by: Dennis Brendel <dbrendel@redhat.com>
This keeps the namespace clean and prevents conflicts. Signed-off-by: Dennis Brendel <dbrendel@redhat.com>
Signed-off-by: Dennis Brendel <dbrendel@redhat.com>
Signed-off-by: Dennis Brendel <dbrendel@redhat.com>
dennisbrendel
force-pushed
the
script-cleanup
branch
from
443197b
to
09f7cc3
Compare
Yarboa
reviewed
Sep 26, 2023
There was a problem hiding this comment.
@dennisbrendel
I see spaces changes, which shell checker do you use?
Maybe we can add it to precommit hooks?
https://github.com/containers/qm/blob/main/.pre-commit-config.yaml#L5
|
I did not use a checker @Yarboa , just looked at the script with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly cosmetic changes:
localvariablesechos