Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e #231

Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix e2e #231

merged 2 commits into from
Oct 4, 2023

Conversation

Yarboa
Copy link
Collaborator

@Yarboa Yarboa commented Oct 2, 2023

Resolves #226

Systemd is not installed under /usr/lib/qm/rootfs
during

podman build   --runtime-flag debug  -f ContainerFile.node1 -t localhost/node:latest

qm.service is failing since no /sbin/init created under /usr/lib/qm/rootfs once container is running

Adding w/a after nodeX container is up, to install systemd under rootfs

@Yarboa
Copy link
Collaborator Author

Yarboa commented Oct 2, 2023

Now i see the whole install under rootfs is not working,
Container is up with systemd but bluchi-agent not installed, this is test failure cause

@rhatdan @dougsland can you advise? is related to exploded container and podman-build?

PS. still checking this
#226 (comment)

Working

Will update PR

tests/e2e/lib/container Outdated Show resolved Hide resolved
Copy link
Collaborator

@dougsland dougsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, @Yarboa have few questions

tests/e2e/lib/container Outdated Show resolved Hide resolved
Resolves containers#226
Systemd is not installed under /usr/lib/qm/rootfs
during  create_qm container
qm is failing since no /sbin/init created under /usr/lib/qm/rootfs

adding cap-add SYS_ADMIN capability for build of nodeX

Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
@dougsland
Copy link
Collaborator

@Yarboa

        Importing GPG key 0x1448D0A3:
         Userid     : "mperina_hirte-snapshot (None) <mperina#hirte-snapshot@copr.fedorahosted.org>"
         Fingerprint: 29FC 7556 AD3D FB1B 5BF0 64E7 02F0 E32E 1448 D0A3
         From       : https://download.copr.fedorainfracloud.org/results/mperina/hirte-snapshot/pubkey.gpg
        npm notice 
        npm notice New major version of npm available! 8.19.4 -> 10.1.0
        npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
        npm notice Run `npm install -g npm@10.1.0` to update!
        npm notice 
        Error: no container with name or ID "qm" found: no such container
        Error: no container with name or ID "qm" found: no such container
        Error: no container with name or ID "qm" found: no such container
        Error: can only create exec sessions on running containers: container state improper

tests/e2e/lib/container Outdated Show resolved Hide resolved
@Yarboa
Copy link
Collaborator Author

Yarboa commented Oct 4, 2023

@dougsland @dennisbrendel
PTAL

tests/e2e/lib/container Outdated Show resolved Hide resolved
Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
@dougsland dougsland merged commit cfbce8d into containers:main Oct 4, 2023
6 checks passed
@dougsland
Copy link
Collaborator

thanks @Yarboa great fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e test is broken
2 participants