Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #243

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix typo #243

merged 1 commit into from
Oct 12, 2023

Conversation

raballew
Copy link
Contributor

Fix typo in the first section of the README.md file.

@dougsland
Copy link
Collaborator

@raballew could you please make the signed-off-by to allow DCO test pass?

@dougsland
Copy link
Collaborator

LGTM

@Yarboa
Copy link
Collaborator

Yarboa commented Oct 12, 2023

LGTM

IT seems that there is an issue with autosd container, please so not merge

+++ podman exec autosd bluechictl list-units qm.localrootfs
Failed to issue method call: Node is offline
Call to manager failed: Input/output error

  • bluechictl_cmd=
    Shared connection to 3.17.190.8 closed.

qm.localrootfs bluchi-agent is down

Verified manually.
Triggered tests again,

Please fix DCO in under checks tab

Signed-off-by: Paul Wallrabe <code@raballew.de>
@raballew
Copy link
Contributor Author

@Yarboa I do not understand how a change to the README.md file should cause this issue. IMO, this seems to be unrelated and should have been present before. It either indicates that something broken was merged before, an issue in TF or flaky tests.

@Yarboa
Copy link
Collaborator

Yarboa commented Oct 12, 2023

@Yarboa I do not understand how a change to the README.md file should cause this issue. IMO, this seems to be unrelated and should have been present before. It either indicates that something broken was merged before, an issue in TF or flaky tests.

It is not, related, but it could point on an issue with this container has an issue
https://quay.io/repository/centos-sig-automotive/autosd,

@odra PTAL
https://gitlab.com/CentOS/automotive/container-images/-/merge_requests/74/diffs

@odra
Copy link
Contributor

odra commented Oct 12, 2023

I fixed that issue in the ci and builds should be working in that repo again.

Also, not related to readme change anyway.

Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Approve with ERR

@dougsland dougsland merged commit 8a5fb8c into containers:main Oct 12, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants