-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: adjust the path for controller.conf #255
Conversation
Currently, e2e is failing with timeout as the AllowedNames is not set correctly. Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
CI error will be fixed as soon the patch is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougsland ci is passing, because of the previous fix
It will fail with it, and actually is failing now
I assume it is a bug in BlueChi
man bluechi-controller.conf | grep -A 4 FILE
FILES
Distributions provide the /usr/share/bluechi/config/controller.conf file which de‐
fines bluechi configuration defaults. Administrators can copy this file to
/etc/bluechi/controller.conf and specify their own configuration.
/etc/bluechi/controller.conf is not read by the controller
CI was failing since, the agents were not recognized by bluechi-controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not forget to change the copy also
Gate tests are failing since it is not fully set
Please change this also
https://github.com/containers/qm/pull/255/files#diff-c60a4ee82a0781e7951ef4194038877d2a9f275dbc32fa70b85947428c31310eR148
And this will cause another failure for updating qm node name, let me check
Just checked, the agent is using the path /etc/bluechi/agent.conf.d/agent.conf
|
agent config is using the /etc/bluechi/agent.conf.d/agent.conf. Nothing to do.
This PR fix skipped corrections Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
Currently, e2e is failing with timeout as the AllowedNames is not set correctly.