Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: adjust the path for controller.conf #255

Merged
merged 1 commit into from
Oct 26, 2023
Merged

e2e: adjust the path for controller.conf #255

merged 1 commit into from
Oct 26, 2023

Conversation

dougsland
Copy link
Collaborator

Currently, e2e is failing with timeout as the AllowedNames is not set correctly.

Currently, e2e is failing with timeout as the AllowedNames is not
set correctly.

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
@dougsland
Copy link
Collaborator Author

@rhatdan @Yarboa PTAL.

@dougsland
Copy link
Collaborator Author

CI error will be fixed as soon the patch is merged.

Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougsland ci is passing, because of the previous fix
It will fail with it, and actually is failing now

I assume it is a bug in BlueChi

man bluechi-controller.conf | grep -A 4 FILE
FILES
Distributions provide the /usr/share/bluechi/config/controller.conf file which de‐
fines bluechi configuration defaults. Administrators can copy this file to
/etc/bluechi/controller.conf and specify their own configuration.

/etc/bluechi/controller.conf is not read by the controller
CI was failing since, the agents were not recognized by bluechi-controller

Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yarboa
Yarboa previously requested changes Oct 26, 2023
Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to change the copy also
Gate tests are failing since it is not fully set
Please change this also
https://github.com/containers/qm/pull/255/files#diff-c60a4ee82a0781e7951ef4194038877d2a9f275dbc32fa70b85947428c31310eR148

And this will cause another failure for updating qm node name, let me check

@dougsland
Copy link
Collaborator Author

Do not forget to change the copy also Gate tests are failing since it is not fully set Please change this also https://github.com/containers/qm/pull/255/files#diff-c60a4ee82a0781e7951ef4194038877d2a9f275dbc32fa70b85947428c31310eR148

And this will cause another failure for updating qm node name, let me check

Just checked, the agent is using the path /etc/bluechi/agent.conf.d/agent.conf

   # Enable bluechi-agent
        echo 'RUN cp /usr/share/bluechi-agent/config/*.conf /etc/bluechi/agent.conf.d/' >> ContainerFile.node"${nodeID}"
        echo 'RUN sed -i -e "s/^#NodeName=/NodeName='"node${nodeID}/"\" \
                '-e "s/^#ManagerHost=/ManagerHost='"${IP_CONTROL_MACHINE}/"\" \
                ' /etc/bluechi/agent.conf.d/agent.conf' >> ContainerFile.node"${nodeID}"
        echo "RUN systemctl enable bluechi-agent &> /dev/null" >> ContainerFile.node"${nodeID}"

@dougsland dougsland dismissed Yarboa’s stale review October 26, 2023 17:34

agent config is using the /etc/bluechi/agent.conf.d/agent.conf. Nothing to do.

@dougsland dougsland merged commit 8afcc1b into containers:main Oct 26, 2023
6 of 7 checks passed
Yarboa added a commit to Yarboa/qm that referenced this pull request Oct 26, 2023
This PR fix skipped corrections

Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
@Yarboa Yarboa mentioned this pull request Oct 26, 2023
dougsland pushed a commit that referenced this pull request Oct 26, 2023
This PR fix skipped corrections

Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants