add shm to ffi tools #349
Merged
add shm to ffi tools #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pengshanyu <yupengshan@hotmail.com>
pengshanyu
requested review from
rhatdan,
lsm5,
dougsland,
Yarboa,
odra,
sandrobonazzola,
dennisbrendel and
priyverm
as code owners
Yarboa
approved these changes
Mar 17, 2024
There was a problem hiding this comment.
LGTM,
@dougsland @dennisbrendel @priyverm PTAL
@pengshanyu do not forget to add this part to https://gitlab.com/CentOS/automotive/container-images/ffi-tools
Once this one is merged
|
LGTM |
Closed
|
I thought we agreed on not just pulling code in here? I.e. update the base-image repo so it can be used in the qm environment? |
Sure, updating the base-image repo has been completed. |
|
I just checked, it has not been updated. We are missing the bits to abstract the involved containers from the rest of the logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added shared memory test to tools/FFI