Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deny_set_scheduler #450

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

pengshanyu
Copy link
Collaborator

@pengshanyu pengshanyu commented May 30, 2024

Add tmt test case for tool "test_sched_setscheduler" to verify that QM environment deny set_scheduler() syscall

resolve #365

Signed-off-by: pengshanyu <yupengshan@hotmail.com>
@Yarboa
Copy link
Collaborator

Yarboa commented May 30, 2024

Add tmt test case for tool "test_sched_setscheduler" according to #365

Test result: out: Trying to pull quay.io/centos-sig-automotive/ffi-tools:latest... out: Getting image source signatures out: Writing manifest to image destination out: 8cd597972703900be2a0612d821a115b418f61ff4b1006e03b429724ec9b9035 out: [ INFO ] set_scheduler() syscall denied in QM. out: Shared connection to localhost closed. 00:02:29 pass /tests/ffi/deny_set_scheduler (on default-0) [1/1] summary: 1 test executed report how: junit order: 50 output: /var/tmp/tmt/run-002/plans/e2e/ffi/report/default-0/junit.xml summary: 1 test passed finish

In description always add resolve #issue_id this way once this PR is closed the issue will also be closed automatically

please explain what tests should do,
Tests out puts are not necessary we have packit ffi gate for it

Signed-off-by: pengshanyu <yupengshan@hotmail.com>
@pengshanyu
Copy link
Collaborator Author

pengshanyu commented May 30, 2024

In description always add resolve #issue_id this way once this PR is closed the issue will also be closed automatically

please explain what tests should do, Tests out puts are not necessary we have packit ffi gate for it

Thanks for the advice. Updated.

tests/ffi/deny_set_scheduler/test.sh Outdated Show resolved Hide resolved
tests/ffi/deny_set_scheduler/test.sh Outdated Show resolved Hide resolved
Signed-off-by: pengshanyu <yupengshan@hotmail.com>
Signed-off-by: pengshanyu <yupengshan@hotmail.com>
Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yarboa
Copy link
Collaborator

Yarboa commented Jun 1, 2024

/packit test

1 similar comment
@Yarboa
Copy link
Collaborator

Yarboa commented Jun 1, 2024

/packit test

@Yarboa Yarboa merged commit 069d854 into containers:main Jun 1, 2024
7 checks passed
@pengshanyu pengshanyu deleted the add-test_sched_setscheduler branch June 3, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FFI: create a test case for sched_setscheduler() syscall
3 participants