Improve error messages when system image missing #1615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For background, see distribution/distribution#3536 |
When inspecting an image index where the platform image for the current architecture is missing, be clearer in the error message about what is wrong. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Jamstah
force-pushed
the
inspect-sparse-errors
branch
from
dcb5c02
to
56b4317
Compare
mtrmac
reviewed
Apr 6, 2022
There was a problem hiding this comment.
Thanks!
- A change like this, which needs to be coordinated between c/image and Skopeo, is a bit convoluted to do. See https://github.com/containers/skopeo/blob/main/CONTRIBUTING.md#dependencies-management , essentially we’ll need a “finished” c/image PR, along with a WIP Skopeo test update PR.
- WRT the “error” words, those were deliberately removed in Do not prepend Error on each wrapped error message. image#1240 . I’m not saying these must not be re-added — just that there probably should be some argument for why these cases are unusual. Cc: @rhatdan
- WRT the “found target platform image” change, sure, that looks useful.
|
Whoops, that's me just being dense and not noticing that code was in image. I'll reopen in image first. Thanks for the previous pr link, will make sure I involve people. |
|
No worries – and we will need a Skopeo PR for the test update anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting an image index where the platform image for the current
architecture is missing, be clearer in the error message about what is
wrong.