store: lock graphLock during Diff #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
force-pushed
the
store-lock-diff
branch
from
62483db
to
ae9e0b8
Compare
flouthoc
approved these changes
Oct 6, 2021
flouthoc
reviewed
Oct 6, 2021
flouthoc
approved these changes
Oct 6, 2021
|
Changing locks, always scares me, could you open a PR with Podman to make sure nothing breaks. |
|
opened here: containers/podman#11882 |
the NaiveDiff driver could cause a mount to happen without any locking in place. For such reason, treat the Diff operation similarly to Mount. Closes: containers#1034 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
store-lock-diff
branch
from
9551f1c
to
0213e6c
Compare
tests pass after reverting to |
|
@vrothberg @nalind PTAL |
|
LGTM |
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/storage
that referenced
this pull request
Jan 7, 2022
Backport the fix for containers#1037 to the release-1.37 branch so that it can then be backported to Podman's v3.4.2-rhel branch for RHEL 8.5.0.2 Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/storage
that referenced
this pull request
Jan 8, 2022
Backport the fix for containers#1037 to the release-1.36 branch so that it can then be backported to Podman's v3.4.2-rhel branch for RHEL 8.5.0.2 Note: containers#1097 was completed to the 1.37 branch in error. Podman v3.4.2-rhel is still on c/storage v1.36 Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/storage
that referenced
this pull request
Jan 9, 2022
Backport the fix for containers#1037 to the release-1.36 branch so that it can then be backported to Podman's v3.4.2-rhel branch for RHEL 8.5.0.2 Note: containers#1097 was completed to the 1.37 branch in error. Podman v3.4.2-rhel is still on c/storage v1.36. containers#1098 was submited to main in error, hopefully the third time is the charm? Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
Jan 9, 2022
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2008997 in the v3.4.2-rhel branch. Bumps c/storage to the version that was available with this PR: containers/storage#1037 Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
Jan 10, 2022
…ring llistxattr Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2008997 in the v3.4.2-rhel branch. Bumps c/storage to v1.36.1 that includes this PR: containers/storage#1037 Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the NaiveDiff driver could cause a mount to happen without any locking
in place.
For such reason, treat the Diff operation similarly to Mount.
Closes: #1034
Alternative to #1033
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com