GetStore modifications, Create GetLocalStorageConfig and SaveLocalStorageConfig #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhatdan PTAL, I'm adding this specifically for the podman reset flags I'm working on but either way the logic here seemed kind of broken |
rhatdan
reviewed
Jan 6, 2022
rhatdan
reviewed
Jan 6, 2022
cdoern
pushed a commit
to cdoern/podman
that referenced
this pull request
Jan 6, 2022
added options to reinstantiate storage after resetting the podman system using podman system reset. --run-root and --graph-root define the runRoot and graphRoot to initiate a new runtime with. --user gets a specified user or uid and generates good approximates for the basic storage locations of that user. these values, once populated into a new libpd runtime, then are used to create a new storage.conf file at the proper location (root or rootless default location). These options allow for a more interactive and useful reset program and ill help eliminate many questions regarding how to configure the basic entities of container storage. depends on containers/storage#1096 Signed-off-by: cdoern <cdoern@redhat.com>
cdoern
pushed a commit
to cdoern/podman
that referenced
this pull request
Jan 7, 2022
added options to reinstantiate storage after resetting the podman system using podman system reset. --run-root and --graph-root define the runRoot and graphRoot to initiate a new runtime with. --user gets a specified user or uid and generates good approximates for the basic storage locations of that user. these values, once populated into a new libpd runtime, then are used to create a new storage.conf file at the proper location (root or rootless default location). These options allow for a more interactive and useful reset program and ill help eliminate many questions regarding how to configure the basic entities of container storage. depends on containers/storage#1096 Signed-off-by: cdoern <cdoern@redhat.com>
cdoern
pushed a commit
to cdoern/podman
that referenced
this pull request
Jan 7, 2022
added options to reinstantiate storage after resetting the podman system using podman system reset. --run-root and --graph-root define the runRoot and graphRoot to initiate a new runtime with. --user gets a specified user or uid and generates good approximates for the basic storage locations of that user. these values, once populated into a new libpd runtime, then are used to create a new storage.conf file at the proper location (root or rootless default location). These options allow for a more interactive and useful reset program and ill help eliminate many questions regarding how to configure the basic entities of container storage. depends on containers/storage#1096 Signed-off-by: cdoern <cdoern@redhat.com>
cdoern
pushed a commit
to cdoern/podman
that referenced
this pull request
Jan 7, 2022
added options to reinstantiate storage after resetting the podman system using podman system reset. --run-root and --graph-root define the runRoot and graphRoot to initiate a new runtime with. --user gets a specified user or uid and generates good approximates for the basic storage locations of that user. these values, once populated into a new libpd runtime, then are used to create a new storage.conf file at the proper location (root or rootless default location). These options allow for a more interactive and useful reset program and ill help eliminate many questions regarding how to configure the basic entities of container storage. depends on containers/storage#1096 Signed-off-by: cdoern <cdoern@redhat.com>
cdoern
changed the title
|
@rhatdan let me know if this is what you meant for editing the toml. I am not sure if there is a cleaner way to override the file but if there is I will do that instead. |
rhatdan
reviewed
Jan 8, 2022
rhatdan
reviewed
Jan 8, 2022
rhatdan
reviewed
Jan 8, 2022
rhatdan
reviewed
Jan 8, 2022
rhatdan
approved these changes
Jan 10, 2022
nalind
reviewed
Jan 10, 2022
nalind
reviewed
Jan 10, 2022
If passing either just a runroot or both a runroot and a graphroot GetStore() was returning when finding a match for JUST the graph root, overriding the runroot and using a different location than specified Also create two new helper functions which add the ability to retrieve and overwrite the toml config in the user's storage.conf file Signed-off-by: cdoern <cdoern@redhat.com>
|
LGTM |
|
flake not related to PR. Merging. |
cdoern
pushed a commit
to cdoern/podman
that referenced
this pull request
Jan 19, 2022
added options to reinstantiate storage after resetting the podman system using podman system reset. --run-root and --graph-root define the runRoot and graphRoot to initiate a new runtime with. these values, once populated into a new libpd runtime, then are used to create a new storage.conf file at the proper location (root or rootless default location). These options allow for a more interactive and useful reset program and ill help eliminate many questions regarding how to configure the basic entities of container storage. depends on containers/storage#1096 Signed-off-by: cdoern <cdoern@redhat.com>
cdoern
pushed a commit
to cdoern/podman
that referenced
this pull request
Jan 20, 2022
added options to reinstantiate storage after resetting the podman system using podman system reset. --run-root and --graph-root define the runRoot and graphRoot to initiate a new runtime with. these values, once populated into a new libpd runtime, then are used to create a new storage.conf file at the proper location (root or rootless default location). These options allow for a more interactive and useful reset program and ill help eliminate many questions regarding how to configure the basic entities of container storage. depends on containers/storage#1096 Signed-off-by: cdoern <cdoern@redhat.com>
cdoern
pushed a commit
to cdoern/podman
that referenced
this pull request
Jan 20, 2022
added options to reinstantiate storage after resetting the podman system using podman system reset. --run-root and --graph-root define the runRoot and graphRoot to initiate a new runtime with. these values, once populated into a new libpd runtime, then are used to create a new storage.conf file at the proper location (root or rootless default location). These options allow for a more interactive and useful reset program and ill help eliminate many questions regarding how to configure the basic entities of container storage. depends on containers/storage#1096 Signed-off-by: cdoern <cdoern@redhat.com>
cdoern
pushed a commit
to cdoern/podman
that referenced
this pull request
Feb 11, 2022
added options to reinstantiate storage after resetting the podman system using podman system reset. --run-root and --graph-root define the runRoot and graphRoot to initiate a new runtime with. these values, once populated into a new libpd runtime, then are used to create a new storage.conf file at the proper location (root or rootless default location). These options allow for a more interactive and useful reset program and ill help eliminate many questions regarding how to configure the basic entities of container storage. depends on containers/storage#1096 Signed-off-by: cdoern <cdoern@redhat.com> Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
cdoern
pushed a commit
to cdoern/podman
that referenced
this pull request
Feb 17, 2022
added options to reinstantiate storage after resetting the podman system using podman system reset. --run-root and --graph-root define the runRoot and graphRoot to initiate a new runtime with. these values, once populated into a new libpd runtime, then are used to create a new storage.conf file at the proper location (root or rootless default location). These options allow for a more interactive and useful reset program and ill help eliminate many questions regarding how to configure the basic entities of container storage. depends on containers/storage#1096 Signed-off-by: cdoern <cdoern@redhat.com>
cdoern
pushed a commit
to cdoern/podman
that referenced
this pull request
Feb 17, 2022
added options to reinstantiate storage after resetting the podman system using podman system reset. --run-root and --graph-root define the runRoot and graphRoot to initiate a new runtime with. these values, once populated into a new libpd runtime, then are used to create a new storage.conf file at the proper location (root or rootless default location). These options allow for a more interactive and useful reset program and ill help eliminate many questions regarding how to configure the basic entities of container storage. depends on containers/storage#1096 Signed-off-by: cdoern <cdoern@redhat.com> Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
cdoern
pushed a commit
to cdoern/podman
that referenced
this pull request
Feb 17, 2022
added options to reinstantiate storage after resetting the podman system using podman system reset. --run-root and --graph-root define the runRoot and graphRoot to initiate a new runtime with. these values, once populated into a new libpd runtime, then are used to create a new storage.conf file at the proper location (root or rootless default location). These options allow for a more interactive and useful reset program and ill help eliminate many questions regarding how to configure the basic entities of container storage. depends on containers/storage#1096 Signed-off-by: cdoern <cdoern@redhat.com> Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If passing either just a runroot or both a runroot and a graphroot
GetStore() was returning when finding a match for JUST the graph root,
overriding the runroot and using a different location than specified.
if either one or the other is passed, default the other option but if both are passed and not found together while searching the store, create a new store.
Also create two new helper functions which add the ability to retrieve and overwrite
the toml config in the user's storage.conf file
Signed-off-by: cdoern cdoern@redhat.com