options: reject empty runroot or graphroot #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
approved these changes
Feb 16, 2023
giuseppe
force-pushed
the
error-out-invalid-dirs
branch
from
e625ec9
to
6ae905a
Compare
make sure that the runroot and graphroot are not empty otherwise we will end up using an empty directory as path prefix and create files in the current directory. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
error-out-invalid-dirs
branch
from
6ae905a
to
9ebdbd9
Compare
|
LGTM |
|
Does Podman work if there is no storage.conf at all? |
if there is no storage at all, we use the default settings that are non empty strings. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure that the runroot and graphroot are not empty otherwise we will end up using an empty directory as path prefix and create files in the current directory.