Unbreak containers without images #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
reviewed
Jan 28, 2017
storage/store.go
Outdated
| @@ -1369,7 +1375,9 @@ func (s *store) DeleteImage(id string, commit bool) (layers []string, err error) | |||
| } | |||
| aContainerByImage := make(map[string]string) | |||
| for _, container := range containers { | |||
| aContainerByImage[container.ImageID] = container.ID | |||
| if container.ImageID != "" { | |||
| aContainerByImage[container.ImageID] = container.ID | |||
There was a problem hiding this comment.
Is it ok if this is not set? Or should it cause an error?
There was a problem hiding this comment.
It should be fine if it's not set, but now that you mention it, this doesn't seem necessary to make this case work. I'll drop it.
Make it possible to create a container without using an underlying image. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
👍 |
|
Thanks, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to create a container without using an underlying image.