This repository has been archived by the owner on Feb 15, 2019. It is now read-only.
Parse the MIME media type from the Content-Type header #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayH5
commented
Jul 20, 2016
JayH5
commented
- Rather than just checking the raw header value
- Don't parse the header if we're streaming everything anyway
* Rather than just checking the raw header value * Don't parse the header if we're streaming everything anyway
|
It's quite common for SSE sources to also specify the character set in the Content-Type header (even though the SSE spec only allows one character set). i.e. It's also technically correct to pass a Content-Type header value with leading or trailing whitespace or with mixed character case. This PR uses |
|
Ouch, how did I miss that 😢 ... |
This was referenced Jul 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.