-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(service): add generic webhook service #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes it possible to ignore errors setting config props and defaults
Codecov Report
@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 63.98% 68.32% +4.33%
==========================================
Files 70 72 +2
Lines 1999 2096 +97
==========================================
+ Hits 1279 1432 +153
+ Misses 606 547 -59
- Partials 114 117 +3
Continue to review full report at Codecov.
|
piksel
force-pushed
the
feature/generic-service
branch
from
March 6, 2021 17:37
4f7d2b3
to
ebdd86f
Compare
piksel
added a commit
that referenced
this pull request
May 14, 2021
* feat(format): improve default props handling this makes it possible to ignore errors setting config props and defaults * feat(service): add generic webhook service * docs(generic): add some basic docs * test(format): add and split additional tests * docs: fix broken markdown formatting
piksel
added a commit
that referenced
this pull request
May 14, 2021
* feat(format): improve default props handling this makes it possible to ignore errors setting config props and defaults * feat(service): add generic webhook service * docs(generic): add some basic docs * test(format): add and split additional tests * docs: fix broken markdown formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a custom webhook service that just posts the
message
to the URL that corresponds to the URL.To use it with another format, set the
template
query field (generic://example.com/api/webhook?template=TEMPLATE_ID
or pass it as a param toSend
:The templates are loaded into the service by using either
or
Where
TEMPLATE_ID
can be anything.