Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Hangouts Chat to Google Chat #170

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Conversation

arnested
Copy link
Member

@arnested arnested commented Jun 1, 2021

Google rebranded Hangouts Chat as Google Chat more than a year ago.

Add/keep hangouts as an alias scheme for googlechat for backward compatibility.

Add/keep `hangouts` as an alias scheme for `googlechat` for backward
compatibility.
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #170 (7a0cfcd) into main (d8371b8) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   63.08%   63.10%   +0.01%     
==========================================
  Files          79       79              
  Lines        2487     2488       +1     
==========================================
+ Hits         1569     1570       +1     
  Misses        780      780              
  Partials      138      138              
Impacted Files Coverage Δ
pkg/services/googlechat/googlechat.go 29.62% <0.00%> (ø)
pkg/services/googlechat/googlechat_config.go 36.36% <ø> (ø)
pkg/router/servicemap.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8371b8...7a0cfcd. Read the comment docs.

@piksel
Copy link
Member

piksel commented Jun 1, 2021

Yeah, this was well overdue. The backwards compatibility was handled nicely. If it was any other service, the auto-generated docs would need some verification that they work correctly, but hangouts google chat doesn't use them since there are no config basically.

@arnested
Copy link
Member Author

arnested commented Jun 1, 2021

I was somewhat surprised that backwards compatibility was so easy. It could probably be done in a ton of other ways, but the ease of this appealed to me.

I don't get the part with the auto-generated docs? Do you have an example of service doing that? And is this something I should add for googlechat as well?

@piksel
Copy link
Member

piksel commented Jun 1, 2021

The most obvious is email/smtp:
https://containrrr.dev/shoutrrr/services/email/
source:
https://github.com/containrrr/shoutrrr/blob/main/docs/services/email.md

Since the URL is exactly like the providers URL, but with a custom scheme, I didn't feel like it added anything for hangouts.

@piksel piksel merged commit 6cdfda1 into containrrr:main Jul 1, 2021
@arnested arnested deleted the googlechat branch July 1, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants