Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slack): add thread/reply support #182

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Conversation

parrasajad
Copy link
Contributor

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I will add this to #179 as well, perhaps also adding logging of the TS of created messages to make it easier to use?

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #182 (47206cb) into main (64eda4a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   63.57%   63.58%   +0.01%     
==========================================
  Files          84       84              
  Lines        2693     2694       +1     
==========================================
+ Hits         1712     1713       +1     
  Misses        832      832              
  Partials      149      149              
Impacted Files Coverage Δ
pkg/services/slack/slack_config.go 92.59% <ø> (ø)
pkg/services/slack/slack_json.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64eda4a...47206cb. Read the comment docs.

@piksel piksel changed the title Add threading support for slack feat(slack): add thread/reply support Jul 7, 2021
@piksel piksel merged commit 8018a47 into containrrr:main Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants