Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): check for nil logger #189

Merged
merged 1 commit into from
Aug 10, 2021
Merged

fix(router): check for nil logger #189

merged 1 commit into from
Aug 10, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Aug 10, 2021

use a safe logging wrapper to avoid dereferencing a nil logger inside the router

fixes #186

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #189 (18c3abe) into main (57b43a3) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   64.06%   64.18%   +0.11%     
==========================================
  Files          86       87       +1     
  Lines        2758     2770      +12     
==========================================
+ Hits         1767     1778      +11     
- Misses        839      840       +1     
  Partials      152      152              
Impacted Files Coverage Δ
pkg/router/router.go 67.34% <100.00%> (+1.03%) ⬆️
pkg/services/teams/teams.go 74.00% <0.00%> (-1.52%) ⬇️
pkg/util/docs.go 100.00% <0.00%> (ø)
pkg/services/teams/teams_config.go 82.25% <0.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b43a3...18c3abe. Read the comment docs.

@piksel piksel merged commit 265789c into main Aug 10, 2021
@piksel piksel deleted the fix/router-logging branch August 10, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initializing services with a Custom URL crashes when no logger has been provided
1 participant