Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(telegram): add generator test #190

Merged
merged 1 commit into from
Aug 10, 2021
Merged

test(telegram): add generator test #190

merged 1 commit into from
Aug 10, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Aug 10, 2021

adds simple simulation of user interaction with telegram generator as a test

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #190 (2c112a9) into main (265789c) will increase coverage by 2.61%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   64.18%   66.79%   +2.61%     
==========================================
  Files          87       87              
  Lines        2770     2774       +4     
==========================================
+ Hits         1778     1853      +75     
+ Misses        840      760      -80     
- Partials      152      161       +9     
Impacted Files Coverage Δ
pkg/services/telegram/telegram_json.go 83.33% <ø> (+16.66%) ⬆️
pkg/services/telegram/telegram_generator.go 74.64% <33.33%> (+74.64%) ⬆️
pkg/services/telegram/telegram_config.go 100.00% <0.00%> (+39.13%) ⬆️
pkg/services/telegram/telegram_client.go 72.00% <0.00%> (+44.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265789c...2c112a9. Read the comment docs.

@piksel
Copy link
Member Author

piksel commented Aug 10, 2021

This is so stupid. The only added non-test code is the ability to replace the default I/O with testable ones. So the "regular" non-test code is obviously not being hit by tests...

@piksel piksel merged commit 603fafc into main Aug 10, 2021
@piksel piksel deleted the test/telegram-gen branch August 10, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant