Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add general basic tests for services #192

Merged
merged 3 commits into from
Aug 10, 2021
Merged

add general basic tests for services #192

merged 3 commits into from
Aug 10, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Aug 10, 2021

this should bump up the test coverage a bit and fix some smaller serialization issues found while testing.

also, this disables the XMPP service (behind a build constraint) until it's deemed stable.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #192 (f109c90) into main (603fafc) will increase coverage by 3.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   71.15%   74.35%   +3.20%     
==========================================
  Files          88       86       -2     
  Lines        2780     2722      -58     
==========================================
+ Hits         1978     2024      +46     
+ Misses        621      511     -110     
- Partials      181      187       +6     
Impacted Files Coverage Δ
pkg/router/servicemap.go 100.00% <100.00%> (ø)
pkg/services/mattermost/mattermost_config.go 91.66% <100.00%> (+41.66%) ⬆️
pkg/services/googlechat/googlechat_config.go 81.81% <0.00%> (+45.45%) ⬆️
pkg/services/googlechat/googlechat.go 77.77% <0.00%> (+48.14%) ⬆️
pkg/services/mattermost/mattermost.go 60.00% <0.00%> (+53.33%) ⬆️
pkg/services/join/join.go 69.23% <0.00%> (+69.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 603fafc...f109c90. Read the comment docs.

@piksel piksel merged commit 281dbde into main Aug 10, 2021
@piksel piksel deleted the test/misc-services branch August 10, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant