Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testing for flag files on windows #1249

Merged
merged 2 commits into from
Apr 18, 2022
Merged

fix: testing for flag files on windows #1249

merged 2 commits into from
Apr 18, 2022

Conversation

piksel
Copy link
Member

@piksel piksel commented Mar 10, 2022

Since testing for file names that contain a : (and not being a legitimate volume letter path, like c:) causes a fatal error on windows, this skips checking such strings and always considers them being literal flag values.

Fixes #1245

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #1249 (93b0897) into main (a5c60a9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
+ Coverage   63.00%   63.02%   +0.02%     
==========================================
  Files          23       23              
  Lines        1500     1501       +1     
==========================================
+ Hits          945      946       +1     
  Misses        471      471              
  Partials       84       84              
Impacted Files Coverage Δ
internal/flags/flags.go 88.85% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c60a9...93b0897. Read the comment docs.

@piksel piksel merged commit 56368a7 into main Apr 18, 2022
@piksel piksel deleted the fix/windows-flag-files branch April 18, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MS Teams notification reporting syntax incorrect in Windows
1 participant