-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify container label usage #1319
Conversation
As discussed in containrrr#1318 - just to aid clarity for new users and also make docker-compose element clear.
You can make the examples tabbed, like on the start page like this: Lines 47 to 65 in 30f36b3
|
Codecov Report
@@ Coverage Diff @@
## main #1319 +/- ##
=======================================
Coverage 63.82% 63.82%
=======================================
Files 23 23
Lines 1534 1534
=======================================
Hits 979 979
Misses 465 465
Partials 90 90 Continue to review full report at Codecov.
|
@piksel good suggestion - still getting my head round mkdocs - have tweaked to 3 tabs for the 2 scenarios, hopefully have got it right but obviously doesn't show up on Github's markdown interpreter! |
sorry had renamed my branches so they made more sense, didn't realise that would automatically close the PR! |
after stupidly using watchtower as the docker-compose example (doh!) have now updated to `someimage`, in-keeping with the other examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but I think the examples should be reduced a bit to make it clearer what is actually required.
Co-authored-by: nils måsén <nils@piksel.se>
Co-authored-by: nils måsén <nils@piksel.se>
Co-authored-by: nils måsén <nils@piksel.se>
Co-authored-by: nils måsén <nils@piksel.se>
Thanks - all very sensible suggestions 👍 |
As discussed in #1318 - just to aid clarity for new users and also make docker-compose element clear.