Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preparations for soft deprecation of legacy notification args #1377

Merged
merged 15 commits into from
Oct 31, 2022

Conversation

piksel
Copy link
Member

@piksel piksel commented Sep 7, 2022

this PR contains initial work for an eventual soft deprecation of legacy notification args.
the main feature added is the notify-upgrade command that can be used as an easy upgrade path for users that currently rely on the legacy notification wrappers.

@piksel piksel changed the title soft deprecation of legacy notification URLs preparations for soft deprecation of legacy notification URLs Sep 7, 2022
@piksel piksel changed the title preparations for soft deprecation of legacy notification URLs preparations for soft deprecation of legacy notification args Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@2102a05). Click here to learn what that means.
Patch coverage: 84.61% of modified lines in pull request are covered.

❗ Current head 9250ada differs from pull request most recent head 733c37b. Consider uploading reports for the commit 733c37b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1377   +/-   ##
=======================================
  Coverage        ?   64.76%           
=======================================
  Files           ?       24           
  Lines           ?     2310           
  Branches        ?        0           
=======================================
  Hits            ?     1496           
  Misses          ?      718           
  Partials        ?       96           
Impacted Files Coverage Δ
pkg/container/container.go 50.58% <ø> (ø)
pkg/container/cgroup_id.go 50.00% <50.00%> (ø)
pkg/notifications/shoutrrr.go 74.46% <85.71%> (ø)
pkg/notifications/email.go 93.87% <100.00%> (ø)
pkg/notifications/gotify.go 71.11% <100.00%> (ø)
pkg/notifications/msteams.go 66.66% <100.00%> (ø)
pkg/notifications/notifier.go 87.25% <100.00%> (ø)
pkg/notifications/slack.go 94.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@piksel piksel marked this pull request as ready for review September 17, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants