Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dark mode #1412

Merged
merged 1 commit into from
Oct 14, 2022
Merged

docs: add dark mode #1412

merged 1 commit into from
Oct 14, 2022

Conversation

carueda
Copy link
Contributor

@carueda carueda commented Oct 5, 2022

This PR adds dark mode to the mkdocs-based documentation site. Pretty straightforward with the great mkdocs tooling. Default mode will reflect user's OS preference, with ability to toggle dark/light mode after that. Main adjustment only in mkdocs.yml, but I also adjusted one style in theme.css so the links in dark mode are a bit more legible.

image

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! There really ought to be a containrrr-dark theme though, but it can be added in another PR.

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 64.98% // Head: 64.98% // No change to project coverage 👍

Coverage data is based on head (aa01601) compared to base (1fc24f6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1412   +/-   ##
=======================================
  Coverage   64.98%   64.98%           
=======================================
  Files          23       23           
  Lines        2319     2319           
=======================================
  Hits         1507     1507           
  Misses        714      714           
  Partials       98       98           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@piksel
Copy link
Member

piksel commented Oct 14, 2022

The codacy/csslint error seems to be just wrong. Ignoring it.

@piksel piksel merged commit a198875 into containrrr:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants