fix: always add missing slashes to link names #1588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes so that container links (which are most of the time actually sourced from
depends-on
labels) are always prefixed with/
. Previously, this was only done when marking dependant containers for restart, but since the names should ALWAYS start with a slash, this fix should be performed every time the container links are iterated.The only downside to this is that it's less performant (as it needs to copy the strings instead of just having the slices point to the same source string), but it should not be noticeable.
Since the links are used to match against container names, only fixing the slashes in one place caused some strange behaviour which should now be fixed: