Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a crawl queue maintenance job #1223

Merged
merged 1 commit into from Jan 21, 2020
Merged

Conversation

@Toflar
Copy link
Member

Toflar commented Jan 20, 2020

I noticed that the crawl queue will grow forever. I'm not sure we should also automatically delete the data once the job is finished because that would mean reloading doesn't work?

At least with the maintenance job you can clean up things easily.

@Toflar Toflar added the defect label Jan 20, 2020
@Toflar Toflar added this to the 4.9 milestone Jan 20, 2020
@Toflar Toflar self-assigned this Jan 20, 2020
@Toflar Toflar requested a review from leofeyer Jan 20, 2020
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Jan 20, 2020

But you probably want this to be merged into the 4.9 branch, don't you?

@Toflar Toflar dismissed leofeyer’s stale review Jan 20, 2020

The base branch was changed.

@Toflar Toflar changed the base branch from master to 4.9 Jan 20, 2020
@Toflar Toflar force-pushed the bugfix/missing-crawl-queue-maintenance branch from ce9de2d to c69cfa1 Jan 20, 2020
@Toflar

This comment has been minimized.

Copy link
Member Author

Toflar commented Jan 20, 2020

True, fixed.

@leofeyer leofeyer merged commit f212706 into 4.9 Jan 21, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 89.89% remains the same compared to 0d89b2e
Details
@leofeyer leofeyer deleted the bugfix/missing-crawl-queue-maintenance branch Jan 21, 2020
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Jan 21, 2020

Thank you @Toflar.

@leofeyer leofeyer changed the title Fixed missing crawl queue maintenance job Add a crawl queue maintenance job Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.