Add a crawl queue maintenance job #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
previously approved these changes
Jan 20, 2020
|
But you probably want this to be merged into the |
Toflar
force-pushed
the
bugfix/missing-crawl-queue-maintenance
branch
from
ce9de2d
to
c69cfa1
Compare
|
True, fixed. |
bytehead
approved these changes
Jan 20, 2020
|
Thank you @Toflar. |
leofeyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the crawl queue will grow forever. I'm not sure we should also automatically delete the data once the job is finished because that would mean reloading doesn't work?
At least with the maintenance job you can clean up things easily.