Use the scope matcher if an element renders differently in BE and FE #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
commented
Aug 28, 2020
ausi
reviewed
Aug 28, 2020
|
Did you skip several content elements on purpose? like |
|
I have left all the |
I guess so, because in the RSS feed (and in newsletters) the backend wildcard output ist most probably not desired. |
|
See 947d77a. |
ausi
approved these changes
Sep 1, 2020
bytehead
approved these changes
Sep 2, 2020
|
I think instead of modifying the current request, we should have pushed a new request to the stack. Shall I prepare a PR for that? |
|
No, I don't think that is necessary. Temporarily adjusting the current request works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall I also try to fix contao/core#7587 here?