Automatically load the services.yml file if it exists

[leofeyer]

In Symfony 4, the services.yml file will be loaded automatically, therefore we should do it, too.

[fritzmg]

Same goes for the routing.yml

[leofeyer]

The routing file is already loaded automatically. 😉

contao/manager-bundle/src/Routing/RouteLoader.php

Lines 70 to 77 in 045cb20

	// Load the routing.yml file if it exists
	if ($configFile = $this->getConfigFile('routing.yml')) {
	$routes = $this->loader->getResolver()->resolve($configFile)->load($configFile);
	if ($routes instanceof RouteCollection) {
	$collection->addCollection($routes);
	}
	}

[fritzmg]

Right, I forgot 🙃

[aschempp]

I'm not sure I like this idea. We should discuss the whole file loading if we want to add this. In Symfony, all files are automatically loaded, not just the services.yml. If we want to add "auto load for everything", we should consider supporting env folders as well etc.

[leofeyer]

Are you sure that Symfony autoloads everything?

Because services.yaml and routing.yaml need to be loaded in different contexts.

-- See https://symfony.com/doc/current/setup/flex.html

[aschempp]

I'm pretty sure it loads everything in packages but I haven't checked how it works exactly.

[fritzmg]

Yes, it loads everything in /config/packages but not everything in /config. imho the Managed Edition should support the same.

[leofeyer]

Yes, it loads everything in /config/packages but not everything in /config. imho the Managed Edition should support the same.

Full ACK. 👍

[aschempp]

There is no config/packages in Contao Managed Edition, and I doubt that really makes sense…?

[aschempp]

config/packages contains the (default) configuration for packages, they are contained in the manager plugin for Contao.

[fritzmg]

Yes but you could put your own bundle configurations there. Supporting the config/packages folder is just a nice to have, since you can do it also via the config.yml.

But loading the /config/services.yml is a must imho.

[leofeyer]

My "Full ACK" meant "do not load everything in the root /config folder", because Symfony does not, either.

[aschempp]

Maybe we should consider having a toggle somewhere.

• "old" style to load app/Resources and support the config.yml (only)
• "new" style to load root folders, have public and support config/packages.yml including environment dirs?

[ausi]

What happens in installations that already have a services.yml which gets loaded via the config.yml. Would they overwrite each other with the same values and therefore don’t cause an issue?

[leofeyer]

Yes, they would. Just like the parameter.yml file, which we also load twice.

[aschempp]

Can we please mark this up for discussion? I don't like the idea of just loading additional files "because Symfony does that". If we load additional files automatically to somewhat follow Symfony Flex, then we should rething the whole thing (like loading everything in prod and dev folders` etc.)

[leofeyer]

You are talking about two different things here. This PR simply adds autoloading for the services.yml file – nothing more. If you want to add autoloading for everything (including sub-folders), you should create a separate PR that we can discuss.

[aschempp]

It's not two different things. It's "do we keep our approach" or "do we support things like flex does". Currently you're mixing the two.