Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Symfony event dispatcher for hooks and callbacks #97

Closed
ghost opened this issue Mar 23, 2015 · 1 comment
Closed

Use the Symfony event dispatcher for hooks and callbacks #97

ghost opened this issue Mar 23, 2015 · 1 comment
Labels
feature

Comments

@ghost
Copy link

ghost commented Mar 23, 2015

Issue by @leofeyer
Thursday Aug 14, 2014 at 19:00 GMT

We want to use the Symfony event dispatcher for hooks and callbacks in a backwards compatible manner.
@leofeyer leofeyer removed the Symfony label Apr 15, 2015
@leofeyer leofeyer mentioned this issue Apr 15, 2015
Closed
@leofeyer
Copy link
Member

Closed in favor of #204.

leofeyer pushed a commit that referenced this issue Oct 1, 2018
@qzminski @leofeyer
Make the Doctrine migrations diff command public (see #97)
01737e4 
Description
-----------

We use DoctrineMigrations and after updating to 4.6 we noticed the following error:

![2018-09-26 at 09 51](https://user-images.githubusercontent.com/193483/46066723-6d118800-c175-11e8-93ee-c02b3254316b.png)

I am not sure but 4.4 can also be affected, so that's why I decided to base the fix on LTS branch.

Do we also need to update the unit tests here?

Commits
-------

9141edbd Make sure that the DoctrineMigrations diff command we override is set to public
fd3a6ca3 Added the missing unit tests
fea568a4 Merge branch '4.6' into hotfix/doctrine-migrations-public-command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leofeyer