Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong schema markup on the FAQ page #1209

Closed
leofeyer opened this issue Jun 2, 2023 · 5 comments · Fixed by #1210
Closed

Wrong schema markup on the FAQ page #1209

leofeyer opened this issue Jun 2, 2023 · 5 comments · Fixed by #1210

Comments

@leofeyer
Copy link
Member

leofeyer commented Jun 2, 2023

There are multiple "@type": "FAQPage" entries in the FAQ list on https://docs.contao.org/manual/en/faq/.
@leofeyer leofeyer changed the title Wrong schema markup Wrong schema markup on the FAQ page Jun 2, 2023
@fritzmg
Copy link
Contributor

fritzmg commented Jun 2, 2023

@Metis77 we will need to revert #1203 unfortunately. We need to find a way to collect the meta data and then output them in one JSON-LD.

@Metis77
Copy link
Contributor

Metis77 commented Jun 2, 2023

Oh thats strange.
When I tested this before the PR with the google rich snippet tester, it was ok.

However combining the FAQs in one entry would be much better, anyway.
Sorrily I am not sure, how to accomplish that wit hugo.

@fritzmg fritzmg mentioned this issue Jun 3, 2023
Merged
@fritzmg
Copy link
Contributor

fritzmg commented Jun 3, 2023 •
edited
Loading

I think we can use .Scratch - however I am having troubles storing an array of FAQ entries there (see https://discourse.gohugo.io/t/creating-an-array-of-maps-in-scratch/44677). See #1210

@fritzmg
Copy link
Contributor

fritzmg commented Jun 3, 2023

Closing in favor of #1210

@fritzmg fritzmg closed this as completed Jun 3, 2023
@fritzmg
Copy link
Contributor

fritzmg commented Jun 14, 2023

@leofeyer should be fine now: https://search.google.com/test/rich-results?url=https%3A%2F%2Fdocs.contao.org%2Fmanual%2Fde%2Ffaq%2F

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix JSON-LD for FAQs contao/docs
3 participants
@leofeyer @Metis77 @fritzmg