Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/faq schema json ld #1203

Merged
merged 5 commits into from
May 24, 2023

Conversation

Metis77
Copy link
Contributor

@Metis77 Metis77 commented May 16, 2023

This adds a shortcode faq.html which replaces the expand.html.
It contains markup for faq schema in the JSON-LD format.

Though I am looking for a better approach to not have an independet faq schema on each shortcode, but to build a list of FAQs together in a single schema notation.

page/layouts/shortcodes/faq.html Outdated Show resolved Hide resolved
thanks

Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
page/layouts/shortcodes/faq.html Outdated Show resolved Hide resolved
page/layouts/shortcodes/faq.html Show resolved Hide resolved
Copy link
Member

@netzarbeiter netzarbeiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Martin

@netzarbeiter netzarbeiter merged commit 2523a0b into contao:main May 24, 2023
fkaminski added a commit to fkaminski/docs that referenced this pull request May 24, 2023
Add Info about shortcode »faq«. 
See contao#1203
fritzmg added a commit that referenced this pull request May 24, 2023
* Update CONTRIBUTING.md

Add Info about shortcode »faq«. 
See #1203

* use code tags

* Update CONTRIBUTING.md

Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>

---------

Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants