-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/faq schema json ld #1203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzmg
requested changes
May 16, 2023
thanks Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
fritzmg
reviewed
May 16, 2023
fritzmg
requested changes
May 16, 2023
fritzmg
requested changes
May 16, 2023
fritzmg
approved these changes
May 18, 2023
netzarbeiter
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Martin
fkaminski
added a commit
to fkaminski/docs
that referenced
this pull request
May 24, 2023
Add Info about shortcode »faq«. See contao#1203
Merged
fritzmg
added a commit
that referenced
this pull request
May 24, 2023
* Update CONTRIBUTING.md Add Info about shortcode »faq«. See #1203 * use code tags * Update CONTRIBUTING.md Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at> --------- Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a shortcode
faq.html
which replaces theexpand.html
.It contains markup for faq schema in the JSON-LD format.
Though I am looking for a better approach to not have an independet faq schema on each shortcode, but to build a list of FAQs together in a single schema notation.