Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file tree widget documentation #1081

Merged
merged 7 commits into from
Sep 26, 2022
Merged

Add file tree widget documentation #1081

merged 7 commits into from
Sep 26, 2022

Conversation

koertho
Copy link
Contributor

@koertho koertho commented Sep 23, 2022

This PR add the documentation for the file tree widget.

Notes:

  • since I haven't tried contao 5 yet, I do not know if there are more changes to this widget
  • I found a deprecation for orderField so I added a deprecation notice in style of the other notices. Since there is no tag for this, I copied the html. I think we need a deprecation tag here, so we can replace this later.
  • in core-bundle tl_content multiSRC field has the multiple eval flag set to true, but from my knowledge this is not necessary, isn't it?
  • this time I've got it compiled local and look good for me :)

P.S.: sorry @fritzmg that I took over your work :)

@fritzmg
Copy link
Contributor

fritzmg commented Sep 23, 2022

in core-bundle tl_content multiSRC field has the multiple eval flag set to true, but from my knowledge this is not necessary, isn't it?

Why would it not be necessary? Or do you mean that 'fieldType' => 'checkbox' is enough and it works even without 'multiple' => true?

Copy link
Contributor

@fritzmg fritzmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor code style adjustments :)

docs/dev/reference/widgets/file-tree.md Outdated Show resolved Hide resolved
docs/dev/reference/widgets/file-tree.md Outdated Show resolved Hide resolved
@koertho
Copy link
Contributor Author

koertho commented Sep 26, 2022

in core-bundle tl_content multiSRC field has the multiple eval flag set to true, but from my knowledge this is not necessary, isn't it?

Why would it not be necessary? Or do you mean that 'fieldType' => 'checkbox' is enough and it works even without 'multiple' => true?

I tried it and it is necassary, I will add it. I though checkbox/ radio will be enough.

@fritzmg fritzmg mentioned this pull request Sep 26, 2022
24 tasks
@koertho
Copy link
Contributor Author

koertho commented Sep 26, 2022

I added the multiple flag, fixed code style, added eval prefix to the eval fields and sorted the keys alphabetical.

docs/dev/reference/widgets/file-tree.md Show resolved Hide resolved
docs/dev/reference/widgets/file-tree.md Outdated Show resolved Hide resolved
docs/dev/reference/widgets/file-tree.md Outdated Show resolved Hide resolved
koertho and others added 4 commits September 26, 2022 10:32
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
@fritzmg
Copy link
Contributor

fritzmg commented Sep 26, 2022

Could you also provide a screenshot of the file tree widget in the gallery content element for example? So that we have an example for isGallery => true.

@fritzmg fritzmg merged commit b44bf4b into contao:main Sep 26, 2022
@fritzmg
Copy link
Contributor

fritzmg commented Sep 26, 2022

Thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants