Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document basicEntities eval option #1373

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Document basicEntities eval option #1373

merged 4 commits into from
Apr 15, 2024

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Apr 14, 2024

See #1370

@fritzmg fritzmg requested a review from ausi April 14, 2024 14:08
@fritzmg fritzmg self-assigned this Apr 14, 2024
@ausi
Copy link
Member

ausi commented Apr 14, 2024

Should we add the info, that in the database they are now always stored as entities?

@fritzmg
Copy link
Contributor Author

fritzmg commented Apr 14, 2024

Should we add the info, that in the database they are now always stored as entities?

I think so, yes.

@fritzmg @ausi
Apply suggestions from code review
bea2c90 
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
@fritzmg fritzmg merged commit 819cc2a into main Apr 15, 2024
@fritzmg fritzmg deleted the eval-basicEntities branch April 15, 2024 08:12
@fritzmg fritzmg mentioned this pull request Apr 15, 2024
Closed
@fritzmg fritzmg linked an issue Apr 15, 2024 that may be closed by this pull request
Contao Docs Update: Evaluation basicEntities for Contao 5 #1370
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi left review comments

Assignees

@fritzmg fritzmg

Labels
Developer Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contao Docs Update: Evaluation basicEntities for Contao 5
2 participants
@fritzmg @ausi