Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove constructors from interfaces #10

Closed
ausi opened this issue Aug 7, 2016 · 4 comments
Closed

Remove constructors from interfaces #10

ausi opened this issue Aug 7, 2016 · 4 comments
Assignees
@ausi
Labels
bug

Comments

@ausi
Copy link
Member

ausi commented Aug 7, 2016

I think constructors should not be part of an interface in most cases. I should remove the constructors of all interfaces in this library.

@contao/developers do you agree?
@ausi ausi added the bug label Aug 7, 2016
@ausi ausi self-assigned this Aug 7, 2016
@aschempp
Copy link
Member

aschempp commented Aug 7, 2016 via email

@Toflar
Copy link
Member

Toflar commented Aug 7, 2016 via email

@leofeyer
Copy link
Member

leofeyer commented Aug 7, 2016

Definitely.

ausi added a commit that referenced this issue Aug 7, 2016
@ausi
Remove constructors from interfaces, closes #10
e5b445b
@ausi
Copy link
Member Author

ausi commented Aug 7, 2016

Done in e5b445b

@ausi ausi closed this as completed Aug 7, 2016
@ausi ausi mentioned this issue Nov 20, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ausi ausi

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ausi @Toflar @aschempp @leofeyer