Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Manifest::composed manifest method #424

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

gpeacock
Copy link
Collaborator

Changes in this pull request

Give a narrative description of what has been changed.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

Provides a way to pre-format a manifest store for injection into a given file format.
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.81%. Comparing base (95ee921) to head (dbb129f).

Files Patch % Lines
sdk/src/manifest.rs 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   79.79%   79.81%   +0.02%     
==========================================
  Files          82       82              
  Lines       25391    25400       +9     
==========================================
+ Hits        20260    20274      +14     
+ Misses       5131     5126       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gpeacock gpeacock requested a review from dyro March 12, 2024 01:34
Copy link
Collaborator

@mauricefisher64 mauricefisher64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gpeacock gpeacock merged commit 039ebf4 into main Mar 12, 2024
22 checks passed
@gpeacock gpeacock deleted the gpeacock/export_composed_manifest branch March 12, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants