Skip to content
This repository has been archived by the owner on Jun 2, 2021. It is now read-only.

Cleanup the command line interface #17

Merged
merged 2 commits into from
Jul 10, 2015
Merged

Cleanup the command line interface #17

merged 2 commits into from
Jul 10, 2015

Conversation

neonichu
Copy link
Contributor

  • Use CLAide instead of escort as CLI parser gem
  • Removed intermediary JSON conversion steps
  • Implicitly validate JSON schema of input files instead of explicit command
  • Cleaned up configuration by offering all options as CLI switches and options in the configuration file
  • Offer aggregate import/publish actions

@neonichu
Copy link
Contributor Author

We should probably first do a release with the better logging from #16 before merging this, as this is quite a huge chunk of stuff to review.

@neonichu
Copy link
Contributor Author

Currently, all actions accept all CLI options, no matter if they are actually used or not. Not sure if that is a good thing ¯_(ツ)_/¯

@pxlpnk
Copy link
Contributor

pxlpnk commented Apr 28, 2015

In general I think that a an option that is not needed in a context should
result in a usage error instead of being silently ignored.

On Tue, Apr 28, 2015 at 4:46 PM, Boris Bügling notifications@github.com
wrote:

Currently, all actions accept all CLI options, no matter if they are
actually used or not. Not sure if that is a good thing ¯_(ツ)_/¯


Reply to this email directly or view it on GitHub
#17 (comment)
.

- Use CLAide instead of escort as CLI parser gem
- Removed intermediary JSON conversion steps
- Implicitly validate JSON schema of input files instead of explicit command
- Cleaned up configuration by offering all options as CLI switches and options in the configuration file
- Offer aggregate import/publish actions
@neonichu
Copy link
Contributor Author

Makes sense, I have split up the options now.

A problem are the aggregate commands like import, it will offer the --threads option, but it will only be applied to the import-entries action, as import-content-model and import-assets don't support them.

@pxlpnk
Copy link
Contributor

pxlpnk commented Jul 10, 2015

Looking good.

pxlpnk added a commit that referenced this pull request Jul 10, 2015
Cleanup the command line interface
@pxlpnk pxlpnk merged commit ffd2613 into master Jul 10, 2015
@pxlpnk pxlpnk deleted the revised-cli branch July 10, 2015 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants