Nullify unresolved links (optional)

[tomxor]

No description provided.

[grncdr]

Would it maybe be better to have an UnresolvedLink extends CDAResource type? null seems a little harsh.

edit: by "better" I mean it could allow clients to react to unresolved links with a bit more information.

[tomxor]

@grncdr That introduces the same problem, only instead of a Map you'd get a UnresolvedLink. Say you have an entry linking to another one, you would be forced to do something like:

CDAResource linkedResource = myEntry.getFields().get("linked");
if (linkedResource instanceof UnresolvedLink) { 
  // ..
} else {
  // ..
}

That unfortunately forces the caller to use reflection in order to figure that out :(

[grncdr]

That's a fair point. Is there some way that we could return null and still let the caller figure out where the broken link is pointing?

[tomxor]

I don't think so, AFAIK the way that the iOS SDK deals with this is simply create a blank CDAEntry/CDAAsset, which potentially could lead to another problem, as one would expect non-null values for required fields and in such cases those would be null.

[tomxor]

#57

[coveralls]

Coverage increased (+0.02%) when pulling 6f587b4 on iss57 into d8123e3 on master.

[neonichu]

FWIW, the iOS SDK indeed has blank objects for this case, and a fetched property to indicate if an instance is blank or not: http://cocoadocs.org/docsets/ContentfulDeliveryAPI/1.4.4/Classes/CDAResource.html#//api/name/fetched

It is not possible to distinguish whether is is indeed a dead link or simply one not included in the response via that property, though.