-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(changesets): move avatar from alpha package to automatic release [AHOY-3166] #2764
Conversation
🦋 Changeset detectedLatest commit: 1d247c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
@Annmary12 Can you rebase on top of @massao Can I ping you for review? Does this look right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to:
- Add the avatar to the
f36-components
package, as a dependency and as an export, also updating the example on how to import. - Also remove the alpha avatar from the
SandpackRenderer.tsx
, here - Remove from LiveEditor here
- Add a changeset so it automatically updates the version to match the other packages and bump the versions.
I think that's it, but will take another look later again.
@Annmary12 can you just add a changeset, the last point, so the package get correctly release, we can do the other points in a follow up once we have a stable version of avatar release.
Done, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of PR
This PR moves Avatar from the alpha package to the automatic release.
PR Checklist
readme.md
file(s)