Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(changesets): move avatar from alpha package to automatic release [AHOY-3166] #2764

Merged
merged 8 commits into from
May 23, 2024

Conversation

Annmary12
Copy link
Contributor

@Annmary12 Annmary12 commented May 22, 2024

Purpose of PR

This PR moves Avatar from the alpha package to the automatic release.

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@Annmary12 Annmary12 requested review from denkristoffer and a team May 22, 2024 18:21
@Annmary12 Annmary12 requested review from damann and a team as code owners May 22, 2024 18:21
Copy link

changeset-bot bot commented May 22, 2024

🦋 Changeset detected

Latest commit: 1d247c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@contentful/f36-components Patch
@contentful/f36-avatar Patch
@contentful/f36-image Patch
@contentful/f36-navbar Patch
@contentful/f36-accordion Patch
@contentful/f36-asset Patch
@contentful/f36-autocomplete Patch
@contentful/f36-badge Patch
@contentful/f36-button Patch
@contentful/f36-card Patch
@contentful/f36-collapse Patch
@contentful/f36-copybutton Patch
@contentful/f36-core Patch
@contentful/f36-datetime Patch
@contentful/f36-datepicker Patch
@contentful/f36-drag-handle Patch
@contentful/f36-entity-list Patch
@contentful/f36-empty-state Patch
@contentful/f36-forms Patch
@contentful/f36-icon Patch
@contentful/f36-list Patch
@contentful/f36-menu Patch
@contentful/f36-modal Patch
@contentful/f36-note Patch
@contentful/f36-notification Patch
@contentful/f36-pagination Patch
@contentful/f36-pill Patch
@contentful/f36-popover Patch
@contentful/f36-skeleton Patch
@contentful/f36-spinner Patch
@contentful/f36-table Patch
@contentful/f36-tabs Patch
@contentful/f36-text-link Patch
@contentful/f36-tooltip Patch
@contentful/f36-typography Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview May 23, 2024 1:03pm

Copy link

github-actions bot commented May 22, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 134.75 KB (+0.16% 🔺) 2.7 s (+0.16% 🔺) 83 ms (+75.82% 🔺) 2.8 s
Module 131.16 KB (+0.03% 🔺) 2.7 s (+0.03% 🔺) 85 ms (+99.69% 🔺) 2.8 s

@denkristoffer denkristoffer requested a review from massao May 23, 2024 07:48
@denkristoffer
Copy link
Collaborator

denkristoffer commented May 23, 2024

@Annmary12 Can you rebase on top of main?

@massao Can I ping you for review? Does this look right?

Copy link
Contributor

@massao massao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to:

  • Add the avatar to the f36-components package, as a dependency and as an export, also updating the example on how to import.
  • Also remove the alpha avatar from the SandpackRenderer.tsx, here
  • Remove from LiveEditor here
  • Add a changeset so it automatically updates the version to match the other packages and bump the versions.

I think that's it, but will take another look later again.

@Annmary12 can you just add a changeset, the last point, so the package get correctly release, we can do the other points in a follow up once we have a stable version of avatar release.

@Annmary12 Annmary12 changed the title feat(changesets): move avatar from alpha package to automatic release [AHOY-3140] feat(changesets): move avatar from alpha package to automatic release [AHOY-3116] May 23, 2024
@Annmary12 Annmary12 changed the title feat(changesets): move avatar from alpha package to automatic release [AHOY-3116] feat(changesets): move avatar from alpha package to automatic release [AHOY-3166] May 23, 2024
@Annmary12 Annmary12 requested a review from massao May 23, 2024 12:28
@Annmary12
Copy link
Contributor Author

You also need to:

  • Add the avatar to the f36-components package, as a dependency and as an export, also updating the example on how to import.
  • Also remove the alpha avatar from the SandpackRenderer.tsx, here
  • Remove from LiveEditor here
  • Add a changeset so it automatically updates the version to match the other packages and bump the versions.

I think that's it, but will take another look later again.

@Annmary12 can you just add a changeset, the last point, so the package get correctly release, we can do the other points in a follow up once we have a stable version of avatar release.

Done, please review

.changeset/config.json Outdated Show resolved Hide resolved
@Annmary12 Annmary12 requested a review from massao May 23, 2024 12:59
Copy link
Contributor

@massao massao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Annmary12 Annmary12 merged commit 514fe2d into main May 23, 2024
12 checks passed
@Annmary12 Annmary12 deleted the feat/AHOY-3140-add-avatar-initials branch May 23, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants